Skip to content

181-logout-feature#187

Merged
khoadnguyen merged 3 commits intodevfrom
181--logout
Oct 30, 2018
Merged

181-logout-feature#187
khoadnguyen merged 3 commits intodevfrom
181--logout

Conversation

@iamalx
Copy link
Copy Markdown
Collaborator

@iamalx iamalx commented Oct 29, 2018

  • included 2 methods to for user to logout
  • added click event for buttton
  • added method that calls user methods and subscribed - passes user.token as a parameter
  • added a patch methods in service

**side note: **

  • had problems saving my docs to my comp, VS asked me to compare my code and choose one

@iamalx iamalx added the code review This PR is ready for code review label Oct 29, 2018
@iamalx iamalx added this to the Week 7 milestone Oct 29, 2018
@iamalx iamalx self-assigned this Oct 29, 2018
@iamalx iamalx requested a review from khoadnguyen October 29, 2018 05:42
@ghost ghost assigned khoadnguyen Oct 30, 2018
@khoadnguyen khoadnguyen merged commit c6d0547 into dev Oct 30, 2018
@ghost ghost removed the code review This PR is ready for code review label Oct 30, 2018
@khoadnguyen khoadnguyen deleted the 181--logout branch October 31, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khoadnguyen khoadnguyen Awaiting requested review from khoadnguyen

Assignees

@khoadnguyen khoadnguyen

@iamalx iamalx

Labels

None yet

Projects

None yet

Milestone

Week 1.7

Development

Successfully merging this pull request may close these issues.

2 participants

@iamalx @khoadnguyen